Skip to content
This repository has been archived by the owner on Feb 18, 2025. It is now read-only.

Improve compatibility with older Rust versions #31

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

b-r-u
Copy link
Contributor

@b-r-u b-r-u commented Jun 3, 2018

Previously, the lin module required Rust 1.22 or newer. It now
compiles with 1.14.

Previously, the `lin` module required Rust 1.22 or newer. It now
compiles with 1.14.
@soc
Copy link
Collaborator

soc commented Jun 21, 2018

@b-r-u I apologize for the delay, I was pretty busy sorting out some blockers for a 1.0 release :-/ ... this looks good to me!

Thanks!

@soc
Copy link
Collaborator

soc commented Jun 21, 2018

Can you add some context to your comment from the issue regarding

it looks like everything works even with 1.13 (from 2016-11-10, which stabilized the ? operator) with a minor change

... but in the above change you remove ? altogether. What's the story here?

@b-r-u
Copy link
Contributor Author

b-r-u commented Jun 21, 2018

The commit removes the ? operator because it was used on an Option (instead of a Result) and this was introduced in Rust 1.22 (https://blog.rust-lang.org/2017/11/22/Rust-1.22.html).

I was mentioning the introduction of the ? operator with Rust 1.13 because I think it was very much embraced by the community and there is limited benefit from supporting older Rust versions by now.

@soc
Copy link
Collaborator

soc commented Jun 21, 2018

@b-r-u Ah, thanks! Now I understood it.

@soc soc merged commit db55657 into dirs-dev:master Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants